Composer API changes for handling dict() #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Jeyaprakash-NK
changed the title
…upyter-plugin-fork into composer-api-changes
Jeyaprakash-NK
changed the title
ojarjur
reviewed
Dec 19, 2024
Comment on lines
35
to
38
| if isinstance(environments, list): | ||
| self.finish(json.dumps(environments, default=lambda x: x.dict())) | ||
| else: | ||
| self.finish(environments) |
There was a problem hiding this comment.
This change is not correct, we should continue to use the json.dumps method to ensure the written output is JSON.
What is the effect you are trying to achieve here?
The only practical difference between this and what we have now is that if the environments value is a dictionary, then the Content-Type header will be set to application/json.
Is that what you are trying to do? If so, then we should set that header regardless of the type of environments.
I.E. merely call self.set_header("Content-Type", "application/json") prior to calling self.finish(...)
There was a problem hiding this comment.
Added Content-Type header will be set to 'application/json' for composer list environments.
ojarjur
approved these changes
Dec 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Content-Type header will be set to 'application/json' for composer list environments.